Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Narrow onChange value type #44777

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Slider] Narrow onChange value type #44777

wants to merge 1 commit into from
+42 −14

Conversation

good-jinu
Copy link

  • Change value and onChange value param type from number | number[] to generic Value

Related to #37854
Inspired by #38753

What's different from PR #38753

  • Removed component field from SliderType -> props
  • No work was done on the code snippets in the docs.
  • Solved every typescript error (not really sure but as far as I tested, it worked)

@good-jinu
[Slider] Narrow onChange value type
03024f7 
- Change value and onChange value param type from `number | number[]` to generic `Value`
@mui-bot
Copy link

mui-bot commented Dec 15, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-44777--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 03024f7

@zannager zannager added the component: slider This is the name of the generic UI component, not the React module! label Dec 16, 2024
@zannager zannager requested a review from DiegoAndai December 16, 2024 14:30
@mj12albert mj12albert added typescript package: material-ui Specific to @mui/material labels Dec 17, 2024
@mj12albert mj12albert changed the title [mui-material][Slider] Narrow onChange value type [Slider] Narrow onChange value type Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai Awaiting requested review from DiegoAndai

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: slider This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@good-jinu @mui-bot @mj12albert @zannager